Bug 69753

Summary: "FIXME: MISSING XINCLUDE CONTENT" if building docs out-of-tree
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-glibAssignee: Simon McVittie <smcv>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: minor    
Priority: low    
Version: git master   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Copy contact-list.c into the ${builddir} so the XInclude in the docs works
Copy contact-list.c into the ${builddir} so the XInclude in the docs works

Description Simon McVittie 2013-09-24 12:11:05 UTC
Created attachment 86444 [details] [review]
Copy contact-list.c into the ${builddir} so the XInclude  in the docs works

This fixes the long-standing bug that if telepathy-glib was built
out-of-tree, the documentation had "FIXME: MISSING XINCLUDE CONTENT"
instead of the example.

---

This finally annoyed me enough to do something about it.
Comment 1 Guillaume Desmottes 2013-09-24 12:50:36 UTC
Comment on attachment 86444 [details] [review]
Copy contact-list.c into the ${builddir} so the XInclude  in the docs works

Review of attachment 86444 [details] [review]:
-----------------------------------------------------------------

++
Comment 2 Simon McVittie 2013-09-24 12:56:24 UTC
Fixed in git for 0.21.2, thanks
Comment 3 Simon McVittie 2013-09-24 13:52:02 UTC
Created attachment 86453 [details] [review]
Copy contact-list.c into the ${builddir} so the XInclude in  the docs works

This fixes the long-standing bug that if telepathy-glib was built
out-of-tree, the documentation had "FIXME: MISSING XINCLUDE CONTENT"
instead of the example.

---

Now with an ugly chmod, because distcheck.
Comment 4 Guillaume Desmottes 2013-09-24 13:53:17 UTC
Comment on attachment 86453 [details] [review]
Copy contact-list.c into the ${builddir} so the XInclude in  the docs works

Review of attachment 86453 [details] [review]:
-----------------------------------------------------------------

++ assuming it distchecks this time :)
Comment 5 Simon McVittie 2013-09-24 14:44:59 UTC
FFS. That patch doesn't work either: it introduces a race condition in which gcc tries to compile ${builddir}/contact-list.c (not the ${srcdir} version!) at the same time that a parallel make is copying it in.

I think the solution is probably to copy the XIncluded files somewhere under docs/ instead, but for now I'm just going to stop blocking on it.
Comment 6 GitLab Migration User 2019-12-03 20:41:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/113.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.