Created attachment 86444 [details] [review] Copy contact-list.c into the ${builddir} so the XInclude in the docs works This fixes the long-standing bug that if telepathy-glib was built out-of-tree, the documentation had "FIXME: MISSING XINCLUDE CONTENT" instead of the example. --- This finally annoyed me enough to do something about it.
Comment on attachment 86444 [details] [review] Copy contact-list.c into the ${builddir} so the XInclude in the docs works Review of attachment 86444 [details] [review]: ----------------------------------------------------------------- ++
Fixed in git for 0.21.2, thanks
Created attachment 86453 [details] [review] Copy contact-list.c into the ${builddir} so the XInclude in the docs works This fixes the long-standing bug that if telepathy-glib was built out-of-tree, the documentation had "FIXME: MISSING XINCLUDE CONTENT" instead of the example. --- Now with an ugly chmod, because distcheck.
Comment on attachment 86453 [details] [review] Copy contact-list.c into the ${builddir} so the XInclude in the docs works Review of attachment 86453 [details] [review]: ----------------------------------------------------------------- ++ assuming it distchecks this time :)
FFS. That patch doesn't work either: it introduces a race condition in which gcc tries to compile ${builddir}/contact-list.c (not the ${srcdir} version!) at the same time that a parallel make is copying it in. I think the solution is probably to copy the XIncluded files somewhere under docs/ instead, but for now I'm just going to stop blocking on it.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/113.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.