| Summary: | get consensus on what protocol names look like | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | general | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 69431, 69854 | ||
| Attachments: |
[spec/next] allow Connection_Manager_Name to start with an underscore
[tp-glib/next 1/4] Allow protocol names to start with "_", because tp-spec 0.99.1 says so [tp-glib/next 2/4] TpAccount: if synthesizing icon name from protocol name, s/_/-/ [tp-glib/next 3/4] TpAccount: use underscores in example service names [tp-glib/next 4/4] tp_connection_manager_check_valid_name: allow starting with underscore [haze/next] Use underscores, not hyphen/minus, in Protocol names [mc/next] Allow client names to start with an underscore |
||
|
Description
Simon McVittie
2013-09-26 18:27:18 UTC
Created attachment 86660 [details] [review] [spec/next] allow Connection_Manager_Name to start with an underscore There's no real reason not to allow this. Created attachment 86661 [details] [review] [tp-glib/next 1/4] Allow protocol names to start with "_", because tp-spec 0.99.1 says so Created attachment 86662 [details] [review] [tp-glib/next 2/4] TpAccount: if synthesizing icon name from protocol name, s/_/-/ Freedesktop icon names conventionally look-like-this, but we've changed the definition of a protocol name in 1.0 so it looks_like_this. Created attachment 86663 [details] [review] [tp-glib/next 3/4] TpAccount: use underscores in example service names The convention is that they look like protocol names, and we've changed the definition of protocol names. Created attachment 86664 [details] [review] [tp-glib/next 4/4] tp_connection_manager_check_valid_name: allow starting with underscore telepathy-spec 0.99.1 doesn't allow this, but I think 1.0 should. Created attachment 86665 [details] [review] [haze/next] Use underscores, not hyphen/minus, in Protocol names Also make sure there are no odd characters in the Protocol name, and make sure it doesn't start with a digit. --- Last patch here. Created attachment 86666 [details] [review] [mc/next] Allow client names to start with an underscore There's no good reason not to, and telepathy-spec 0.99.1 says they can. --- Sorry, *this* is the last patch. Comment on attachment 86660 [details] [review] [spec/next] allow Connection_Manager_Name to start with an underscore Review of attachment 86660 [details] [review]: ----------------------------------------------------------------- ok. Comment on attachment 86661 [details] [review] [tp-glib/next 1/4] Allow protocol names to start with "_", because tp-spec 0.99.1 says so Review of attachment 86661 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 86662 [details] [review] [tp-glib/next 2/4] TpAccount: if synthesizing icon name from protocol name, s/_/-/ Review of attachment 86662 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 86663 [details] [review] [tp-glib/next 3/4] TpAccount: use underscores in example service names Review of attachment 86663 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 86664 [details] [review] [tp-glib/next 4/4] tp_connection_manager_check_valid_name: allow starting with underscore Review of attachment 86664 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 86665 [details] [review] [haze/next] Use underscores, not hyphen/minus, in Protocol names Review of attachment 86665 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 86666 [details] [review] [mc/next] Allow client names to start with an underscore Review of attachment 86666 [details] [review]: ----------------------------------------------------------------- ++ 0.99.2, thanks |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.