| Summary: | MC: remove support for non-Requests altogether | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | mission-control | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | xclaesse |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 69854 | ||
| Attachments: |
[mc/master 1/3] Remove obsolete fake CM and client
[mc/master 2/3] Fix comments that talk about MC calling GetStatus [mc/master 3/3] McdConnection: refuse to deal with pre-Requests connections |
||
|
Description
Simon McVittie
2013-09-26 18:40:57 UTC
Created attachment 86671 [details] [review] [mc/master 1/3] Remove obsolete fake CM and client We don't use these: mctest has better infrastructure. Created attachment 86672 [details] [review] [mc/master 2/3] Fix comments that talk about MC calling GetStatus We don't assume that GetStatus will be called, but if we did, it'd be one more thing to port to next. Delete the comments to avoid confusion. Created attachment 86673 [details] [review] [mc/master 3/3] McdConnection: refuse to deal with pre-Requests connections If it implements Requests, all is good; if it doesn't, just disconnect it before it can cause trouble (e.g. new channels turning up and not being dispatched correctly). (In reply to comment #3) > Created attachment 86673 [details] [review] > [mc/master 3/3] McdConnection: refuse to deal with pre-Requests connections The observant will notice that this adds the error SOFTWARE_UPDATE_REQUIRED. That's also included in Bug #69854 (I developed this first). Looks good, all our CMs have been ported for years anyway, right? Fixed in git for 5.17.0, thanks |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.