Bug 69856 - MC: remove support for non-Requests altogether
Summary: MC: remove support for non-Requests altogether
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 69854
  Show dependency tree / graph
 
Reported: 2013-09-26 18:40 UTC by Simon McVittie
Modified: 2013-09-27 14:06 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
[mc/master 1/3] Remove obsolete fake CM and client (17.15 KB, patch)
2013-09-26 18:41 UTC, Simon McVittie 		Details | Splinter Review
[mc/master 2/3] Fix comments that talk about MC calling GetStatus (5.67 KB, patch)
2013-09-26 18:41 UTC, Simon McVittie 		Details | Splinter Review
[mc/master 3/3] McdConnection: refuse to deal with pre-Requests connections (23.91 KB, patch)
2013-09-26 18:42 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2013-09-26 18:40:57 UTC 
Some pre-next cleanup.
Comment 1 Simon McVittie 2013-09-26 18:41:35 UTC 
Created attachment 86671 [details] [review]
[mc/master 1/3] Remove obsolete fake CM and client

We don't use these: mctest has better infrastructure.
Comment 2 Simon McVittie 2013-09-26 18:41:51 UTC 
Created attachment 86672 [details] [review]
[mc/master 2/3] Fix comments that talk about MC calling GetStatus

We don't assume that GetStatus will be called, but if we did,
it'd be one more thing to port to next. Delete the comments to avoid
confusion.
Comment 3 Simon McVittie 2013-09-26 18:42:11 UTC 
Created attachment 86673 [details] [review]
[mc/master 3/3] McdConnection: refuse to deal with pre-Requests  connections

If it implements Requests, all is good; if it doesn't, just
disconnect it before it can cause trouble (e.g. new channels
turning up and not being dispatched correctly).
Comment 4 Simon McVittie 2013-09-26 18:43:24 UTC 
(In reply to comment #3)
> Created attachment 86673 [details] [review]
> [mc/master 3/3] McdConnection: refuse to deal with pre-Requests  connections

The observant will notice that this adds the error SOFTWARE_UPDATE_REQUIRED. That's also included in Bug #69854 (I developed this first).
Comment 5 Xavier Claessens 2013-09-26 18:56:43 UTC 
Looks good, all our CMs have been ported for years anyway, right?
Comment 6 Simon McVittie 2013-09-27 14:06:32 UTC 
Fixed in git for 5.17.0, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.