| Summary: | Glamor on r600g crashes Xserver | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Krzysztof A. Sobiecki <sobkas> |
| Component: | Drivers/Gallium/r600 | Assignee: | Default DRI bug account <dri-devel> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Crash log
Xorg log with shader dump and sb dump Xorg backtrace It fixes my crash problem patch patch |
||
That looks exactly like the crash I see on PALM ASICs, too. I just didn't have time to properly report it yet. Something is going wrong in SB's gcm phase. This only seems to happen on certain ASICs, it works fine on TURKS. Please attach the output with R600_DEBUG=ps,vs You should be able to obtain a better backtrace if you do this: 1) Delete /etc/X11/core. 2) Reproduce the crash. This should create a new core file in /etc/X11. 3) Run: gdb /usr/bin/Xorg /etc/X11/core 4) Type bt in gdb. The paths may differ depending on your distribution. Please attach the backtrace you will get from gdb. Created attachment 87094 [details]
Xorg log with shader dump and sb dump
Created attachment 87095 [details]
Xorg backtrace
Created attachment 87098 [details] [review] It fixes my crash problem It fixes my crash problem. Maybe code needs more checks for null values? As always my patch is subpar, You shouldn't use it. Created attachment 87148 [details] [review] patch This patch should fix this issue. (In reply to comment #6) > It fixes my crash problem. Maybe code needs more checks for null values? > As always my patch is subpar, You shouldn't use it. Checking for null is not enough in this case, it may prevent segfault but generated shader code would be incorrect anyway, when we have null there it means that something is already broken. (In reply to comment #7) > Created attachment 87148 [details] [review] [review] > patch > > This patch should fix this issue. > > > (In reply to comment #6) > > It fixes my crash problem. Maybe code needs more checks for null values? > > As always my patch is subpar, You shouldn't use it. > > Checking for null is not enough in this case, it may prevent segfault but > generated shader code would be incorrect anyway, when we have null there it > means that something is already broken. Yes it fixed the problem. Thank You. When it will be pushed into git I will close this bug. I can also confirm that the patch fixes the issue. When Your patch will go into a git? Created attachment 87597 [details] [review] patch This is an improved version of the patch, please test. (In reply to comment #11) > Created attachment 87597 [details] [review] [review] > patch > > This is an improved version of the patch, please test. Glamor acceleration with mesa + this patch works fine, will try to run piglit. Fix pushed with commit 62c8149472903a2f3fc4d319c3799b9e729419d5 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 87079 [details] Crash log When I try to run Xserver and radeon driver with glamor accel method I get a crash from Xserver. It happens when I'm starting blackbox or Gnome(from GDM3). While GNOME causes crash, gdm3 works.