Bug 70108

Summary: [bisected e64633e8c3a5498998a45ab721bf80edca101cf5] regression: bad rendering on r600g
Product: Mesa Reporter: Alexandre Demers <alexandre.f.demers>
Component: Drivers/Gallium/r600Assignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Alexandre Demers 2013-10-04 02:43:32 UTC 
I noticed a couple of days ago a regression on some demo applications where the light or shadows wouldn't be rendered correctly. They form lines. This can be observed testing Unigine where light reflecting on water or on the dock will not be rendered correctly.

Bisecting gave me the following result:
git bisect bad
e64633e8c3a5498998a45ab721bf80edca101cf5 is the first bad commit
commit e64633e8c3a5498998a45ab721bf80edca101cf5
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Sun Sep 22 13:06:27 2013 +0200

    r600g,radeonsi: share r600_texture.c
    
    The function r600_choose_tiling is new and needs a review.
    
    The only change in functionality is that it enables 2D tiling for compressed
    textures on SI. It was probably accidentally turned off.
    
    v2: don't make scanout buffers linear

:040000 040000 138f5235123706d30903e259a8c7651ee53e9fd5 79f8e5d3497c5d2a3c71bb6ba968ecf5fd4c1a1a M	src

I'm using HD 6950 on ArchLinux 64, with latest drm and ddx from git.
Comment 1 Marek Olšák 2013-10-04 11:49:19 UTC 
This should be fixed by c7d91a6f13d9dafe47cfa948619083258bc47cb0. Can you confirm?
Comment 2 Alexandre Demers 2013-10-04 14:03:09 UTC 
Yes, indeed, it is fixed by that commit. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.