Bug 70690

Summary:	reserved identifier violation
Product:	pkg-config	Reporter:	Markus Elfring <Markus.Elfring>
Component:	src	Assignee:	pkg-config
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Markus Elfring 2013-10-20 19:20:15 UTC

I would like to point out that identifiers like "_Flag" and "_Package" do not fit to the expected naming convention of the C language standard.
http://cgit.freedesktop.org/pkg-config/tree/pkg.h?id=715cc306b0e4add06523b8fcce49867da469a728#n48

Would you like to adjust your selection for unique names?
https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Comment 1 Dan Nicholson 2013-12-14 17:09:52 UTC

Thanks for passing that along, but I'd prefer not to fix this here. pkg.h is an internal header, so any issues are limited to building pkg-config itself. I'll wait for any actual conflicts to arise and fix then. :)

Comment 2 Markus Elfring 2013-12-15 19:05:30 UTC

(In reply to comment #1)

I would appreciate if this software will not depend on undefined behaviour.
https://www.securecoding.cert.org/confluence/display/seccode/CC.+Undefined+Behavior#CC.UndefinedBehavior-ub_106

Comment 3 Dan Nicholson 2013-12-16 13:41:15 UTC

Fine. Fixed in e1d44d2.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.