Bug 70690 - reserved identifier violation
Summary: reserved identifier violation
Status: RESOLVED FIXED
Alias: None
Product: pkg-config
Classification: Unclassified
Component: src (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: pkg-config
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-20 19:20 UTC by Markus Elfring
Modified: 2013-12-16 13:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Markus Elfring 2013-10-20 19:20:15 UTC 
I would like to point out that identifiers like "_Flag" and "_Package" do not fit to the expected naming convention of the C language standard.
http://cgit.freedesktop.org/pkg-config/tree/pkg.h?id=715cc306b0e4add06523b8fcce49867da469a728#n48

Would you like to adjust your selection for unique names?
https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Comment 1 Dan Nicholson 2013-12-14 17:09:52 UTC 
Thanks for passing that along, but I'd prefer not to fix this here. pkg.h is an internal header, so any issues are limited to building pkg-config itself. I'll wait for any actual conflicts to arise and fix then. :)
Comment 2 Markus Elfring 2013-12-15 19:05:30 UTC 
(In reply to comment #1)

I would appreciate if this software will not depend on undefined behaviour.
https://www.securecoding.cert.org/confluence/display/seccode/CC.+Undefined+Behavior#CC.UndefinedBehavior-ub_106
Comment 3 Dan Nicholson 2013-12-16 13:41:15 UTC 
Fine. Fixed in e1d44d2.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.