Bug 70887

Hi,

A suggested new version for the symbols/il file is at
https://raw.github.com/shaib/xkeyboard-config/si1452-2013/symbols/il

It only changes the default variant. You can see the differences from the current file in 
https://github.com/shaib/xkeyboard-config/compare/si1452-2013?expand=1
(where you can also follow the changes I made; the reordering of keys makes the initial diff look like the variant was completely rewritten).

About the reordering -- it works towards, but does not yet completely comply with, your contribution guideline that keys should be ordered alphabetically. The current ordering is more about behavior (separate alphabetic keys, affected by lock, from non-alphabetic keys) and physical location. Please advise if this ordering is acceptable or should be changed in some way.

About the validity -- As Yaron noted above, the new standard has been published, but regretfully the Standards Institute of Israel does not make it freely available. I have access to it because I participate in the standards committee that wrote this standard.

Finally, the change is not presented as a single commit yet; if you want it that way, please let me know -- I'll squash it into one commit on the master branch of my repo.

Thanks,
Shai.

(In reply to comment #1)
> Hi,
> 
> A suggested new version for the symbols/il file is at
> https://raw.github.com/shaib/xkeyboard-config/si1452-2013/symbols/il

Just a tiny comment: `empty` is not a valid keysym, you should use `NoSymbol` instead.

(In reply to comment #2)
> (In reply to comment #1)
> > https://raw.github.com/shaib/xkeyboard-config/si1452-2013/symbols/il
> 
> Just a tiny comment: `empty` is not a valid keysym, you should use
> `NoSymbol` instead.

Thanks; can you also point me to a comprehensive list of recognized keysyms? I'd like to use names rather than unicode code-points wherever possible.

Shai.

(In reply to comment #3)
> Thanks; can you also point me to a comprehensive list of recognized keysyms?

The main set are defined in:
http://cgit.freedesktop.org/xorg/proto/x11proto/tree/keysymdef.h#n49

There's a few other special & vendor specific ones defined in other headers
in that package though.

Hi, repo updated according to comments; please confirm the current version is ok, then I'll squash the commits so you can pull it.

For easier reference: 
Links to current version and diff against master are in Comment 1.
The repo is at https://github.com/shaib/xkeyboard-config
In case you were following, the new changes are:

    Replaced "empty" with "NoSymbol"
    Replaced unicode points for Euro and New Sheqel with keysyms
    Some comment changes

Thanks,
Shai.

To me it looks ok. Please combine the commits into one

I updated the master branch of my repo from the freedesktop repo, and added the new implementation as one commit -- you should be able to do a fast-forward merge.

Thanks,
Shai.

Could you please attach the git-formatted version here, please, for convenience?

Thank you

Created attachment 91107 [details] [review]
Patch for adding SI1452 (2013) support

Attached.

Thanks,
Shai.

thank you, it is in git now

Thank you,

Shai.