Bug 70887 - New Hebrew keyboard standard SI1452 not yet implemented
Summary: New Hebrew keyboard standard SI1452 not yet implemented
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-26 11:15 UTC by sh.yaron@gmail.com
Modified: 2014-01-15 07:15 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch for adding SI1452 (2013) support (6.95 KB, patch)
2013-12-22 00:35 UTC, Shai Berger
Details | Splinter Review

Description sh.yaron@gmail.com 2013-10-26 11:15:05 UTC
The Standard Institution of Israel published a draft for a new Hebrew layout marked as SI1452 (ת״י 1452), the standard is published at the following address:
https://portal.sii.org.il/heb/standardization/teken/?tid=e9166c38-c384-4a5b-8e91-bbb4f08003d3

And also explained further in both English and Hebrew at the following address:
http://www.lingnu.com/howto/78-si1452.html

The following layout is an expansion and a modification of the current LyX layout.

This layout should be included in xkb-configure.

The latest draft (available via the download location) is 5, somewhat incompatible with previous versions of xkb, presumably due to character level expansion.

Kind regards,
Yaron Shahrabani.
Comment 1 Shai Berger 2013-11-27 22:57:36 UTC
Hi,

A suggested new version for the symbols/il file is at
https://raw.github.com/shaib/xkeyboard-config/si1452-2013/symbols/il

It only changes the default variant. You can see the differences from the current file in 
https://github.com/shaib/xkeyboard-config/compare/si1452-2013?expand=1
(where you can also follow the changes I made; the reordering of keys makes the initial diff look like the variant was completely rewritten).

About the reordering -- it works towards, but does not yet completely comply with, your contribution guideline that keys should be ordered alphabetically. The current ordering is more about behavior (separate alphabetic keys, affected by lock, from non-alphabetic keys) and physical location. Please advise if this ordering is acceptable or should be changed in some way.

About the validity -- As Yaron noted above, the new standard has been published, but regretfully the Standards Institute of Israel does not make it freely available. I have access to it because I participate in the standards committee that wrote this standard.

Finally, the change is not presented as a single commit yet; if you want it that way, please let me know -- I'll squash it into one commit on the master branch of my repo.

Thanks,
Shai.
Comment 2 Ran Benita 2013-11-27 23:46:10 UTC
(In reply to comment #1)
> Hi,
> 
> A suggested new version for the symbols/il file is at
> https://raw.github.com/shaib/xkeyboard-config/si1452-2013/symbols/il

Just a tiny comment: `empty` is not a valid keysym, you should use `NoSymbol` instead.
Comment 3 Shai Berger 2013-11-27 23:59:31 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > https://raw.github.com/shaib/xkeyboard-config/si1452-2013/symbols/il
> 
> Just a tiny comment: `empty` is not a valid keysym, you should use
> `NoSymbol` instead.

Thanks; can you also point me to a comprehensive list of recognized keysyms? I'd like to use names rather than unicode code-points wherever possible.

Shai.
Comment 4 Alan Coopersmith 2013-11-28 00:27:27 UTC
(In reply to comment #3)
> Thanks; can you also point me to a comprehensive list of recognized keysyms?

The main set are defined in:
http://cgit.freedesktop.org/xorg/proto/x11proto/tree/keysymdef.h#n49

There's a few other special & vendor specific ones defined in other headers
in that package though.
Comment 5 Shai Berger 2013-11-30 15:11:09 UTC
Hi, repo updated according to comments; please confirm the current version is ok, then I'll squash the commits so you can pull it.

For easier reference: 
Links to current version and diff against master are in Comment 1.
The repo is at https://github.com/shaib/xkeyboard-config
In case you were following, the new changes are:

    Replaced "empty" with "NoSymbol"
    Replaced unicode points for Euro and New Sheqel with keysyms
    Some comment changes

Thanks,
Shai.
Comment 6 Sergey V. Udaltsov 2013-12-18 22:05:33 UTC
To me it looks ok. Please combine the commits into one
Comment 7 Shai Berger 2013-12-19 20:09:54 UTC
I updated the master branch of my repo from the freedesktop repo, and added the new implementation as one commit -- you should be able to do a fast-forward merge.

Thanks,
Shai.
Comment 8 Sergey V. Udaltsov 2013-12-21 23:04:06 UTC
Could you please attach the git-formatted version here, please, for convenience?

Thank you
Comment 9 Shai Berger 2013-12-22 00:35:09 UTC
Created attachment 91107 [details] [review]
Patch for adding SI1452 (2013) support

Attached.

Thanks,
Shai.
Comment 10 Sergey V. Udaltsov 2014-01-15 01:06:25 UTC
thank you, it is in git now
Comment 11 Shai Berger 2014-01-15 07:15:55 UTC
Thank you,

Shai.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.