| Summary: | some intermittent MC test failures | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | mission-control | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
mctest: fix invalid method implementations
account-manager/avatar.py: fix race condition by combining expect_many calls |
||
|
Description
Simon McVittie
2013-10-29 14:16:11 UTC
Created attachment 88291 [details] [review] mctest: fix invalid method implementations There's no variable called s - I wanted a string "s". The relevant test, account-manager/param-types.py, only failed intermittently, because it's a matter of timing whether telepathy-glib loads the .manager file or introspects the ConnectionManager. Created attachment 88292 [details] [review] account-manager/avatar.py: fix race condition by combining expect_many calls The test account-storage plugin uses GDBus, so its signals have an undefined order with respect to MC's dbus-glib signals. We don't actually care about the order anyway, so expect them all in one big expect_many call. Comment on attachment 88291 [details] [review] mctest: fix invalid method implementations Review of attachment 88291 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 88292 [details] [review] account-manager/avatar.py: fix race condition by combining expect_many calls Review of attachment 88292 [details] [review]: ----------------------------------------------------------------- ++ Fixed in git for 5.17.0 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.