Bug 7150

Summary:	xcb-util build fixes for Solaris / Sun compilers
Product:	XCB	Reporter:	Alan Coopersmith <alan.coopersmith>
Component:	Utils	Assignee:	Jamey Sharp <jamey>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	All
OS:	Solaris
Whiteboard:
i915 platform:		i915 features:
Attachments:	Check for gcc & Sun cc in configure.ac and use correct flags to turn on more warnings for each Rename "len" to "namelen" to avoid m4 substitution

Description Alan Coopersmith 2006-06-07 12:06:34 UTC

Two simple fixes were needed to get xcb-util building on Solaris:
1) Only use -Wall with gcc
2) Solaris m4 replaces "len" with "0" for some reason, causing 
   xcb-util/atom/atoms.c to fail when GetAtomName tries to declare "int 0;"
   Renaming "len" to "namelen" solves this.

Patches for both will be attached momentarily.

Comment 1 Alan Coopersmith 2006-06-07 12:11:54 UTC

Created attachment 5838 [details] [review]
Check for gcc & Sun cc in configure.ac and use correct flags to turn on more warnings for each

Comment 2 Alan Coopersmith 2006-06-07 12:12:28 UTC

Created attachment 5839 [details] [review]
Rename "len" to "namelen" to avoid m4 substitution

Comment 3 Jamey Sharp 2006-11-12 18:19:43 UTC

Sorry it took me so long to get around to these. Both fixes are committed and
pushed. Thanks for your contribution!

Comment 4 Jamey Sharp 2006-11-12 18:21:53 UTC

...and actually marking it fixed would help.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.