Bug 7150 - xcb-util build fixes for Solaris / Sun compilers
Summary: xcb-util build fixes for Solaris / Sun compilers
Status: RESOLVED FIXED
Alias: None
Product: XCB
Classification: Unclassified
Component: Utils (show other bugs)
Version: unspecified
Hardware: All Solaris
: high normal
Assignee: Jamey Sharp
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-07 12:06 UTC by Alan Coopersmith
Modified: 2006-11-12 18:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Check for gcc & Sun cc in configure.ac and use correct flags to turn on more warnings for each (4.15 KB, patch)
2006-06-07 12:11 UTC, Alan Coopersmith 		Details | Splinter Review
Rename "len" to "namelen" to avoid m4 substitution (902 bytes, patch)
2006-06-07 12:12 UTC, Alan Coopersmith 		Details | Splinter Review
View All

Description Alan Coopersmith 2006-06-07 12:06:34 UTC 
Two simple fixes were needed to get xcb-util building on Solaris:
1) Only use -Wall with gcc
2) Solaris m4 replaces "len" with "0" for some reason, causing 
   xcb-util/atom/atoms.c to fail when GetAtomName tries to declare "int 0;"
   Renaming "len" to "namelen" solves this.

Patches for both will be attached momentarily.
Comment 1 Alan Coopersmith 2006-06-07 12:11:54 UTC 
Created attachment 5838 [details] [review]
Check for gcc & Sun cc in configure.ac and use correct flags to turn on more warnings for each
Comment 2 Alan Coopersmith 2006-06-07 12:12:28 UTC 
Created attachment 5839 [details] [review]
Rename "len" to "namelen" to avoid m4 substitution
Comment 3 Jamey Sharp 2006-11-12 18:19:43 UTC 
Sorry it took me so long to get around to these. Both fixes are committed and
pushed. Thanks for your contribution!
Comment 4 Jamey Sharp 2006-11-12 18:21:53 UTC 
...and actually marking it fixed would help.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.