Bug 71526

Summary: Memory leak in dbus-daemon
Product: dbus Reporter: Radoslaw Pajak <r.pajak>
Component: coreAssignee: Havoc Pennington <hp>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard: review+
i915 platform: i915 features:
Attachments: Patch

Description Radoslaw Pajak 2013-11-12 09:15:01 UTC
Created attachment 89074 [details] [review]
Patch

Found in master branch. Allocated memory is not freed correctly if an error occures. Patch attached.
Comment 1 Simon McVittie 2013-11-12 10:40:43 UTC
Comment on attachment 89074 [details] [review]
Patch

Review of attachment 89074 [details] [review]:
-----------------------------------------------------------------

Makes sense.
Comment 2 Simon McVittie 2013-11-12 11:02:18 UTC
I was initially concerned that this might be a double/multiple-free (which is a potential security vulnerability), but from reading the code, it just calls dbus_free(NULL) repeatedly, which is always harmless. So, yes it's just a leak.

Fixed in git for 1.6.20, 1.7.10. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.