Bug 71526 - Memory leak in dbus-daemon
Summary: Memory leak in dbus-daemon
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-11-12 09:15 UTC by Radoslaw Pajak
Modified: 2013-11-12 11:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch (1.04 KB, patch)
2013-11-12 09:15 UTC, Radoslaw Pajak 		Details | Splinter Review
View All

Description Radoslaw Pajak 2013-11-12 09:15:01 UTC 
Created attachment 89074 [details] [review]
Patch

Found in master branch. Allocated memory is not freed correctly if an error occures. Patch attached.
Comment 1 Simon McVittie 2013-11-12 10:40:43 UTC 
Comment on attachment 89074 [details] [review]
Patch

Review of attachment 89074 [details] [review]:
-----------------------------------------------------------------

Makes sense.
Comment 2 Simon McVittie 2013-11-12 11:02:18 UTC 
I was initially concerned that this might be a double/multiple-free (which is a potential security vulnerability), but from reading the code, it just calls dbus_free(NULL) repeatedly, which is always harmless. So, yes it's just a leak.

Fixed in git for 1.6.20, 1.7.10. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.