Bug 7237

Summary: apps may have empty appdefaultdir
Product: xorg Reporter: Jeremy C. Reed <reed>
Component: App/xeditAssignee: Jeremy C. Reed <reed>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: high    
Version: git   
Hardware: x86 (IA32)   
OS: NetBSD   
Whiteboard:
i915 platform: i915 features:

Description Jeremy C. Reed 2006-06-15 08:12:43 UTC
Many (all?) apps (not just xedit) configure don't check for xt version
so may get an empty appdefaultdir, causing these resources to be installed to
top-level /.

The fix is either:

-PKG_CHECK_MODULES(APPDEFS, xt)
+PKG_CHECK_MODULES(APPDEFS, xt >= 1.0)

Or:

 PKG_CHECK_MODULES(APPDEFS, xt)
 appdefaultdir=$(pkg-config --variable=appdefaultdir xt)
+if test "x$appdefaultdir" = "x" ; then
+	appdefaultdir=${datadir}/X11/app-defaults;
+fi 
 AC_SUBST(appdefaultdir)

Or both?

I will fix these. Let me know what to do.
Comment 1 Daniel Stone 2007-02-27 01:32:33 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 2 Jeremy Huddleston Sequoia 2011-09-25 00:58:55 UTC
I just pushed changes for xconsole, xdm, xedit, and xlogo.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.