Bug 7237 - apps may have empty appdefaultdir
Summary: apps may have empty appdefaultdir
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xedit (show other bugs)
Version: git
Hardware: x86 (IA32) NetBSD
: high normal
Assignee: Jeremy C. Reed
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-15 08:12 UTC by Jeremy C. Reed
Modified: 2011-09-25 00:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Jeremy C. Reed 2006-06-15 08:12:43 UTC 
Many (all?) apps (not just xedit) configure don't check for xt version
so may get an empty appdefaultdir, causing these resources to be installed to
top-level /.

The fix is either:

-PKG_CHECK_MODULES(APPDEFS, xt)
+PKG_CHECK_MODULES(APPDEFS, xt >= 1.0)

Or:

 PKG_CHECK_MODULES(APPDEFS, xt)
 appdefaultdir=$(pkg-config --variable=appdefaultdir xt)
+if test "x$appdefaultdir" = "x" ; then
+	appdefaultdir=${datadir}/X11/app-defaults;
+fi 
 AC_SUBST(appdefaultdir)

Or both?

I will fix these. Let me know what to do.
Comment 1 Daniel Stone 2007-02-27 01:32:33 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 2 Jeremy Huddleston Sequoia 2011-09-25 00:58:55 UTC 
I just pushed changes for xconsole, xdm, xedit, and xlogo.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.