Bug 73902

Summary:	build: move ARCH_LIBS definition over the first usage
Product:	Mesa	Reporter:	Paul Seidler <pl.seidler>
Component:	Mesa core	Assignee:	Matt Turner <mattst88>
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	normal
Priority:	medium
Version:	git
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch to move ARCH_LIBS definition over the first usage build: don't set noinst_LTLIBRARIES with ARCH_LIBS to early build: move ARCH_LIBS definition outside of ASM definition

Description Paul Seidler 2014-01-21 22:54:42 UTC

Else I get:
undefined symbol: _mesa_streaming_load_memcpy

Maybe related to the recent automake version I use.

Regards
Paul

PS: If possible please cherry pick it to 10.0, I think #73900 is required for this

Comment 1 Paul Seidler 2014-01-21 22:57:15 UTC

Created attachment 92551 [details] [review]
patch to move ARCH_LIBS definition over the first usage

Comment 2 Paul Seidler 2014-01-21 23:40:49 UTC

Created attachment 92552 [details] [review]
build: don't set noinst_LTLIBRARIES with ARCH_LIBS to early

Comment 3 Paul Seidler 2014-01-21 23:45:46 UTC

Ok, I still think the first patch isn't proper, sadly the second one doesn't work (First test worked, not sure why.). Anyway I will rethink about it after some sleep.

Sorry for the noise.

Comment 4 Paul Seidler 2014-01-22 00:30:29 UTC

Created attachment 92553 [details] [review]
build: move ARCH_LIBS definition outside of ASM definition

Comment 5 Paul Seidler 2014-01-22 00:31:05 UTC

It has not left me alone. The first patch was correct but the reasoning not. The reason is simply that the used function which was introduced with 6f2e81 isn't required for assembling and so should be defined outside of the asm stuff.

Comment 6 Matt Turner 2014-02-01 23:03:25 UTC

Thanks! Committed and marked for stable.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.