Bug 73902 - build: move ARCH_LIBS definition over the first usage
Summary: build: move ARCH_LIBS definition over the first usage
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Matt Turner
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 22:54 UTC by Paul Seidler
Modified: 2014-02-01 23:03 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch to move ARCH_LIBS definition over the first usage (1.05 KB, patch)
2014-01-21 22:57 UTC, Paul Seidler 		Details | Splinter Review
build: don't set noinst_LTLIBRARIES with ARCH_LIBS to early (860 bytes, patch)
2014-01-21 23:40 UTC, Paul Seidler 		Details | Splinter Review
build: move ARCH_LIBS definition outside of ASM definition (1.12 KB, patch)
2014-01-22 00:30 UTC, Paul Seidler 		Details | Splinter Review
Show Obsolete (2) View All

Description Paul Seidler 2014-01-21 22:54:42 UTC 
Else I get:
undefined symbol: _mesa_streaming_load_memcpy

Maybe related to the recent automake version I use.

Regards
Paul

PS: If possible please cherry pick it to 10.0, I think #73900 is required for this
Comment 1 Paul Seidler 2014-01-21 22:57:15 UTC 
Created attachment 92551 [details] [review]
patch to move ARCH_LIBS definition over the first usage
Comment 2 Paul Seidler 2014-01-21 23:40:49 UTC 
Created attachment 92552 [details] [review]
build: don't set noinst_LTLIBRARIES with ARCH_LIBS to early
Comment 3 Paul Seidler 2014-01-21 23:45:46 UTC 
Ok, I still think the first patch isn't proper, sadly the second one doesn't work (First test worked, not sure why.). Anyway I will rethink about it after some sleep.

Sorry for the noise.
Comment 4 Paul Seidler 2014-01-22 00:30:29 UTC 
Created attachment 92553 [details] [review]
build: move ARCH_LIBS definition outside of ASM definition
Comment 5 Paul Seidler 2014-01-22 00:31:05 UTC 
It has not left me alone. The first patch was correct but the reasoning not. The reason is simply that the used function which was introduced with 6f2e81 isn't required for assembling and so should be defined outside of the asm stuff.
Comment 6 Matt Turner 2014-02-01 23:03:25 UTC 
Thanks! Committed and marked for stable.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.