Bug 73956

Summary: SIGSEGV when passing GL_NONE to glReadBuffer
Product: Mesa Reporter: ahmabdabd
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: medium CC: ahmabdabd
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch against git 6ec210989fa10847091f06fcfcab77dd07618dff
Full backtrace

Description ahmabdabd 2014-01-23 06:21:58 UTC
Created attachment 92635 [details]
Patch against git  6ec210989fa10847091f06fcfcab77dd07618dff

Mesa crashes instead of returning GL_INVALID_ENUM when GL_NONE is passed as an argument to glReadBuffer.

Attached is a patch to achieve the desired behavior.
Comment 1 Tapani Pälli 2014-01-23 07:30:43 UTC
Can you post the backtrace? GL_NONE is a valid value for glReadBuffer() and there seems toe be plenty of Piglit tests using this so you might be hitting some corner case here.
Comment 2 ahmabdabd 2014-01-23 08:44:33 UTC
Created attachment 92646 [details]
Full backtrace

The source code line in 
Ogre::GL3PlusFBOManager::_createTempFramebuffer ()
    at /home/mega/elbatriq-linux/Ogre3D-sources/Ogre3D-source/RenderSystems/GL3Plus/src/OgreGL3PlusFBORenderTexture.cpp:186

is glReadBuffer(GL_NONE)
Comment 3 Brian Paul 2014-01-23 18:21:17 UTC
Fixed with commit f7c118ffbfdafaccd4ec05d4a040d07e120c5090

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.