Bug 73956 - SIGSEGV when passing GL_NONE to glReadBuffer
SIGSEGV when passing GL_NONE to glReadBuffer
Status: RESOLVED FIXED
Product: Mesa
Classification: Unclassified
Component: Mesa core
git
All All
: medium major
Assigned To: mesa-dev
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-23 06:21 UTC by ahmabdabd
Modified: 2014-01-23 18:21 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch against git 6ec210989fa10847091f06fcfcab77dd07618dff (529 bytes, text/plain)
2014-01-23 06:21 UTC, ahmabdabd
Details
Full backtrace (3.46 KB, text/plain)
2014-01-23 08:44 UTC, ahmabdabd
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ahmabdabd 2014-01-23 06:21:58 UTC
Created attachment 92635 [details]
Patch against git  6ec210989fa10847091f06fcfcab77dd07618dff

Mesa crashes instead of returning GL_INVALID_ENUM when GL_NONE is passed as an argument to glReadBuffer.

Attached is a patch to achieve the desired behavior.
Comment 1 Tapani Pälli 2014-01-23 07:30:43 UTC
Can you post the backtrace? GL_NONE is a valid value for glReadBuffer() and there seems toe be plenty of Piglit tests using this so you might be hitting some corner case here.
Comment 2 ahmabdabd 2014-01-23 08:44:33 UTC
Created attachment 92646 [details]
Full backtrace

The source code line in 
Ogre::GL3PlusFBOManager::_createTempFramebuffer ()
    at /home/mega/elbatriq-linux/Ogre3D-sources/Ogre3D-source/RenderSystems/GL3Plus/src/OgreGL3PlusFBORenderTexture.cpp:186

is glReadBuffer(GL_NONE)
Comment 3 Brian Paul 2014-01-23 18:21:17 UTC
Fixed with commit f7c118ffbfdafaccd4ec05d4a040d07e120c5090