Bug 7414

Summary: gccmakedep mutilates arguments containing "'" or " * "
Product: xorg Reporter: Peter Breitenlohner <peb>
Component: * OtherAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: high Keywords: patch
Version: 6.9.0   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 5799    
Attachments:
Description Flags
patch for gccmakedep to properly quote argumenets passed on to gcc none

Description Peter Breitenlohner 2006-07-04 08:10:08 UTC 
When compiling Xorg-6.9.0 I noticed 78 strange gcc warnings, that are
due to the fact that the gccmakedep shell script mutilates arguments passed on
to gcc if the contain "'" and/or " * ".

The attached patch fixes this problem (and is inspired by the way
autoconf/configure handles the very same problem).

The second part of the patch might be useless because filenames containing
blanks will probably fail at many other places.
Comment 1 Peter Breitenlohner 2006-07-04 08:11:22 UTC 
Created attachment 6115 [details] [review]
patch for gccmakedep to properly quote argumenets passed on to gcc
Comment 2 Daniel Stone 2007-02-27 01:32:46 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 3 Matt Turner 2010-12-03 13:21:06 UTC 
I sent this to xorg-devel@ so it won't rot here for all eternity. You're CC'd on it.

In the future, just send patches to the mailing list. They're harder to ignore that way.

This bug report's not doing any good, so I'm going to close it.
Comment 4 Julien Cristau 2010-12-04 04:31:44 UTC 
reopening.
Comment 5 Matt Turner 2011-03-01 20:24:30 UTC 
Committed as a29912840d4baccc6d3819e9a2b25ba9d5cb7f7e
Comment 6 Julien Cristau 2011-03-02 02:48:59 UTC 
and closing...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.