| Summary: | Segfault in st_finalize_texture with Texture Buffer | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Ian Milligan <ianmllgn> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | 10.0 | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Vertex shader using texture buffer.
Failing code. |
||
|
Description
Ian Milligan
2014-01-30 23:00:05 UTC
I forgot to add that I am using the r600g driver. Could you please attach the backtrace? Oops, I meant mesa 10.0 of course. Here is the backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff26296f4 in st_finalize_texture (ctx=0x7ffff1324010, pipe=0xf1b2e0, tObj=0xf25d70) at state_tracker/st_cb_texture.c:1488 1488 state_tracker/st_cb_texture.c: No such file or directory. (gdb) bt #0 0x00007ffff26296f4 in st_finalize_texture (ctx=0x7ffff1324010, pipe=0xf1b2e0, tObj=0xf25d70) at state_tracker/st_cb_texture.c:1488 #1 0x00007ffff26147aa in finalize_textures (st=0xfc5660) at state_tracker/st_atom_texture.c:420 #2 0x00007ffff260d546 in st_validate_state (st=0xfc5660) at state_tracker/st_atom.c:202 #3 0x00007ffff2619c40 in st_Clear (ctx=0x7ffff1324010, mask=2) at state_tracker/st_cb_clear.c:390 #4 0x00007ffff249901a in _mesa_Clear (mask=16384) at main/clear.c:202 #5 0x000000000040970c in sbXU_info () #6 0x00007ffff3dd9010 in ?? () #7 0x0000000000000000 in ?? () Do you have a code sample how to reproduce this? I do but it's not written in C. Let me try to write something which can reproduce this. Created attachment 93095 [details]
Vertex shader using texture buffer.
Created attachment 93096 [details]
Failing code.
The segfault appears to occur when glClear is called while a vertex shader expecting a texture buffer is loaded, but no texture is bound. This can be reproduced simply by loading the attached vertex shader and calling glClear. It appears that loading a shader which expects a texture buffer causes the first texture unit's target to be set to TEXTURE_BUFFER. When st_validate_state is called without a texture bound to this texture unit, st_validate_texture is called on this texture unit's texture object. However st_validate_texture expects a texture object with target TEXTURE_BUFFER to have defined the field BufferObject, causing the null pointer dereference. Unfortunately, I'm not sure where the fault lies here. Should be fixed with http://cgit.freedesktop.org/mesa/mesa/commit/?id=c6dbcf10dff1f8343a26081f5489ef732ebb5460 Indeed. The fix will be backported to stable branches if it hasn't been backported already. Closing. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.