Bug 74754

Summary:	utils test is failing
Product:	Spice	Reporter:	Allison Lortie (desrt) <desrt>
Component:	spice-gtk	Assignee:	Spice Bug List <spice-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	utils tests: fix sign comparison problem

Description Allison Lortie (desrt) 2014-02-09 17:37:20 UTC

'make check' currently fails in the utils test with:

GSpice:ERROR:util.c:155:test_set_bit: assertion failed: (dest[j] == tests[i].dest[j])

Patch coming.

Comment 1 Allison Lortie (desrt) 2014-02-09 17:37:59 UTC

Created attachment 93718 [details] [review]
utils tests: fix sign comparison problem

This test compares a guint8 and a gchar with '==' which fails when comparing
240 to -16, even though these are the same byte value.  Add an explicit
'guchar' cast to correct the problem.

Comment 2 Marc-Andre Lureau 2014-02-10 13:53:24 UTC

pushed, thanks
http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=e189c976943f346b712dd51285a30ff8cd4e819a

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.