Bug 74754 - utils test is failing
Summary: utils test is failing
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: spice-gtk (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-09 17:37 UTC by Allison Lortie (desrt)
Modified: 2014-02-10 13:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
utils tests: fix sign comparison problem (907 bytes, patch)
2014-02-09 17:37 UTC, Allison Lortie (desrt) 		Details | Splinter Review
View All

Description Allison Lortie (desrt) 2014-02-09 17:37:20 UTC 
'make check' currently fails in the utils test with:

GSpice:ERROR:util.c:155:test_set_bit: assertion failed: (dest[j] == tests[i].dest[j])

Patch coming.
Comment 1 Allison Lortie (desrt) 2014-02-09 17:37:59 UTC 
Created attachment 93718 [details] [review]
utils tests: fix sign comparison problem

This test compares a guint8 and a gchar with '==' which fails when comparing
240 to -16, even though these are the same byte value.  Add an explicit
'guchar' cast to correct the problem.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.