| Summary: | [next] Create TpTLSCertificate objects using TpClientFactory | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | CC: | xclaesse |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-tls-cert-76175 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 76111 | ||
|
Description
Guillaume Desmottes
2014-03-14 14:23:54 UTC
- You're missing the _TP_AVAILABLE_IN_ for tp_client_factory_ensure_tls_certificate(). - "Returns: (transfer full): a new TLS certificate proxy" --> "a reference to a" is better IMO, like others ensure_foo. I see you did the same for protocol. - tp_client_factory_ensure_tls_certificate() is missing the variant g_return_val_if_fail(). Like tp_proxy_get_factory(conn_or_chan) == self to be sure we don't mix proxies from different factories. - I think we should not add the vfuncs, but they can be removed later with the rest. So that's not merge blocker for now. (In reply to comment #2) > - You're missing the _TP_AVAILABLE_IN_ for > tp_client_factory_ensure_tls_certificate(). > > - "Returns: (transfer full): a new TLS certificate proxy" --> "a reference > to a" is better IMO, like others ensure_foo. I see you did the same for > protocol. > > - tp_client_factory_ensure_tls_certificate() is missing the variant > g_return_val_if_fail(). Like tp_proxy_get_factory(conn_or_chan) == self to > be sure we don't mix proxies from different factories. All fixed in both branches. +1 Merged to next. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.