Bug 76175 - [next] Create TpTLSCertificate objects using TpClientFactory
Summary: [next] Create TpTLSCertificate objects using TpClientFactory
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/ca...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 76111
  Show dependency treegraph
 
Reported: 2014-03-14 14:23 UTC by Guillaume Desmottes
Modified: 2014-03-17 14:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Guillaume Desmottes 2014-03-14 14:23:54 UTC
As for bug #75881 we may want to remove the vfunc functions.
Comment 2 Xavier Claessens 2014-03-14 15:52:06 UTC
 - You're missing the _TP_AVAILABLE_IN_ for tp_client_factory_ensure_tls_certificate().

 - "Returns: (transfer full): a new TLS certificate proxy" --> "a reference to a" is better IMO, like others ensure_foo. I see you did the same for protocol.

 - tp_client_factory_ensure_tls_certificate() is missing the variant g_return_val_if_fail(). Like tp_proxy_get_factory(conn_or_chan) == self to be sure we don't mix proxies from different factories.

 - I think we should not add the vfuncs, but they can be removed later with the rest. So that's not merge blocker for now.
Comment 3 Guillaume Desmottes 2014-03-14 16:09:09 UTC
(In reply to comment #2)
>  - You're missing the _TP_AVAILABLE_IN_ for
> tp_client_factory_ensure_tls_certificate().
> 
>  - "Returns: (transfer full): a new TLS certificate proxy" --> "a reference
> to a" is better IMO, like others ensure_foo. I see you did the same for
> protocol.
> 
>  - tp_client_factory_ensure_tls_certificate() is missing the variant
> g_return_val_if_fail(). Like tp_proxy_get_factory(conn_or_chan) == self to
> be sure we don't mix proxies from different factories.

All fixed in both branches.
Comment 4 Xavier Claessens 2014-03-14 19:27:03 UTC
+1
Comment 5 Guillaume Desmottes 2014-03-17 14:26:11 UTC
Merged to next.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.