Bug 78381

Summary:	[next] TpBaseProtocol should be able to avoid implementing Avatars, per-instance
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Guillaume Desmottes <guillaume.desmottes>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	77189
Bug Blocks:	68661
Attachments:	base-protocol: get_avatar_details() now return a boolean

Description Simon McVittie 2014-05-07 09:17:40 UTC

Related to Bug #77189 and Bug #77197.

My Haze update for Bug #77189 attempts to remove Protocol.I.Avatars from the TpBaseProtocol object for protocols that do not actually implement avatars. Unfortunately, this is not sufficient to remove it from the Interfaces property, which has already been cached.

We should either have a way for a Protocol that implements the get_avatar_details() vfunc to say "actually, I don't" - returning FALSE from that vfunc, perhaps? - or decide that this situation is OK, and spec some meaningless values for the properties (min = max = 0, etc.).

Comment 1 Guillaume Desmottes 2014-05-15 09:15:04 UTC

Created attachment 99076 [details] [review]
base-protocol: get_avatar_details() now return a boolean

Comment 2 Guillaume Desmottes 2014-05-15 09:21:56 UTC

http://cgit.collabora.com/git/user/cassidy/telepathy-gabble/log/?h=next-avatar-78381
http://cgit.collabora.com/git/user/cassidy/telepathy-salut/log/?h=next-avatar-78381
http://cgit.collabora.com/git/user/cassidy/telepathy-haze/log/?h=next-avatar-78381

No Idle and Rakia change needed.

Comment 3 Simon McVittie 2014-05-15 10:14:04 UTC

Comment on attachment 99076 [details] [review]
base-protocol: get_avatar_details() now return a boolean

Review of attachment 99076 [details] [review]:
-----------------------------------------------------------------

Looks ideal

Comment 4 Simon McVittie 2014-05-15 10:15:43 UTC

CM patches look good, please revert <http://cgit.collabora.com/git/user/cassidy/telepathy-haze/commit/?h=next-avatar-78381&id=d6cc7dab2034f9f8eb7e841107f7249da47f7604> if possible.

Please apply the same change to the Folks regression tests where necessary (making them compile is enough).

Comment 5 Guillaume Desmottes 2014-05-15 11:54:08 UTC

Patch reverted. Folks was not impacted. All merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.