Related to Bug #77189 and Bug #77197. My Haze update for Bug #77189 attempts to remove Protocol.I.Avatars from the TpBaseProtocol object for protocols that do not actually implement avatars. Unfortunately, this is not sufficient to remove it from the Interfaces property, which has already been cached. We should either have a way for a Protocol that implements the get_avatar_details() vfunc to say "actually, I don't" - returning FALSE from that vfunc, perhaps? - or decide that this situation is OK, and spec some meaningless values for the properties (min = max = 0, etc.).
Created attachment 99076 [details] [review] base-protocol: get_avatar_details() now return a boolean
http://cgit.collabora.com/git/user/cassidy/telepathy-gabble/log/?h=next-avatar-78381 http://cgit.collabora.com/git/user/cassidy/telepathy-salut/log/?h=next-avatar-78381 http://cgit.collabora.com/git/user/cassidy/telepathy-haze/log/?h=next-avatar-78381 No Idle and Rakia change needed.
Comment on attachment 99076 [details] [review] base-protocol: get_avatar_details() now return a boolean Review of attachment 99076 [details] [review]: ----------------------------------------------------------------- Looks ideal
CM patches look good, please revert <http://cgit.collabora.com/git/user/cassidy/telepathy-haze/commit/?h=next-avatar-78381&id=d6cc7dab2034f9f8eb7e841107f7249da47f7604> if possible. Please apply the same change to the Folks regression tests where necessary (making them compile is enough).
Patch reverted. Folks was not impacted. All merged.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.