|Summary:||no anisotropic filtering in a native Half-Life 2|
|Product:||Mesa||Reporter:||Damian Nowak <nowaker>|
|Component:||Drivers/Gallium/radeonsi||Assignee:||Default DRI bug account <dri-devel>|
|Status:||RESOLVED FIXED||QA Contact:|
|i915 platform:||i915 features:|
|Attachments:||Bring radeonsi anisotropic filtering setup in line with r600g|
Description Damian Nowak 2014-05-10 17:57:35 UTC
Setting the anisotropic filtering in a native Half-Life 2 doesn't have any effect. Only bilinear and trilinear filtering work. Just have a look at the screenshot, it's perfectly visible the texture on the ground lacks some nice filtering. http://upload.nowaker.net/nwkr/1399744500_hl2-aniso.jpg I'm playing on Radeon 7870 with mesa 10.1.3 (Gallium/Glamor) and Arch Linux (rolling release, always up to date with the upstream). Please consider this issue a feature request (if there is no anisotropic filtering implemented yet) or a bug (if it is implemented but doesn't work for me).
Comment 1 Michel Dänzer 2014-05-13 04:32:26 UTC
Created attachment 98957 [details] [review] Bring radeonsi anisotropic filtering setup in line with r600g Does this patch help?
Comment 2 Grigori Goronzy 2014-05-13 20:12:51 UTC
Anisotropic filtering is also broken for me in other applications, it looks like it's broken with radeonsi overall. Your patch seems to fix it, Michel. I didn't really verify correctness, but 16x anisotropic doesn't look like a blurry mess anymore. :)
Comment 3 Damian Nowak 2014-05-13 20:15:29 UTC
Hey, I will give it a try. Can you point me to the git repo with the sources I should patch?
Comment 4 Damian Nowak 2014-05-13 22:22:21 UTC
Works now. See the difference. http://upload.nowaker.net/nwkr/1399744500_hl2-aniso.jpg http://upload.nowaker.net/nwkr/1400019691_2014-05-14_00001.jpg
Comment 5 Marek Olšák 2014-05-13 22:32:26 UTC
The fix will certainly look like a performance regression when Michael tests radeonsi next time. Be ready for the shocking news on Phoronix. :)
Comment 6 Michel Dänzer 2014-05-14 14:24:33 UTC
Commit: c5828b0599a5c00ebab488b795c63a21f1dc53cd URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c5828b0599a5c00ebab488b795c63a21f1dc53cd Author: Michel Dänzer <firstname.lastname@example.org> Date: Wed May 14 16:30:33 2014 +0900 radeonsi: Fix anisotropic filtering state setup
on Feb 22, 2017 at 15:08:46.
(provided by the Example extension).