Bug 78948

Summary: [HSW/BYT/BDW]igt/pm_rpm/system-suspend fails
Product: DRI Reporter: Guo Jinxian <jinxianx.guo>
Component: DRM/IntelAssignee: Damien Lespiau <damien.lespiau>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs, james.ausmus, przanoni, yi.sun
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg
none
dmesg none

Description Guo Jinxian 2014-05-20 06:38:55 UTC 
Created attachment 99391 [details]
dmesg

==System Environment==
--------------------------
Regression: No. 
It's new case

Non-working platforms: BDW

==kernel==
--------------------------
-nightly: 0791a325e382bfd2b06673655b90ed64682a519a(fails)
-queued: b6fdd0f2b990006daba19eec676b632faa523fc8(fails)
    Author: Shashank Sharma <shashank.sharma@intel.com>
    Date:   Mon May 19 20:54:03 2014 +0530

    drm/i915: Add MIPI mmio reg base

    This patch adds a mmio base address variable for DSI display,
    to make the DSI code generic, so that, if required, the same code
    can be re-used for future platforms with different mmio base.

    Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>
    Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
    [danvet: Appease checkpatch.]
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    
-fixes: e95a2f7509f5219177d6821a0a8754f93892ca56 (works)
    Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Date:   Thu May 8 15:09:19 2014 +0300

    drm/i915: Increase WM memory latency values on SNB

    On SNB the BIOS provided WM memory latency values seem insufficient to
    handle high resolution displays.

    In this particular case the display mode was a 2560x1440@60Hz, which
    makes the pixel clock 241.5 MHz. It was empirically found that a memory
    latency value if 1.2 usec is enough to avoid underruns, whereas the BIOS
    provided value of 0.7 usec was clearly too low. Incidentally 1.2 usec
    is what the typical BIOS provided values are on IVB systems.

    Increase the WM memory latency values to at least 1.2 usec on SNB.
    Hopefully this won't have a significant effect on power consumption.

    v2: Increase the latency values regardless of the pixel clock

    Cc: Robert N <crshman@gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70254
    Tested-by: Robert Navarro <crshman@gmail.com>
    Tested-by: Vitaly Minko <vitaly.minko@gmail.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>

==Bug detailed description==
-----------------------------
igt/pm_rpm/system-suspend fails

Output:
./pm_rpm --run-subtest system-suspend            IGT-Version: 1.6-gd71add5 (x86_64) (Linux: 3.15.0-rc3_drm-intel-next-queued_b6fdd0_20140520+ x86_64)
Runtime PM support: 1
PC8 residency support: 1
rtcwake: assuming RTC uses UTC ...
rtcwake: wakeup from ""mem"" using /dev/rtc0 at Tue May 20 18:28:22 2014
Test assertion failure function system_suspend_subtest, file pm_rpm.c:1390:
Last errno: 2, No such file or directory
Failed assertion: wait_for_suspended()
Subtest system-suspend: FAIL


==Reproduce steps==
---------------------------- 
1. ./pm_rpm --run-subtest system-suspend
Comment 1 Daniel Vetter 2014-05-20 09:17:47 UTC 
Is this the only subtest of pm_rpm that fails on bdw? If runtime pm is busted in general then yeah, this will fail too.
Comment 2 Imre Deak 2014-05-20 11:36:43 UTC 
If this is the only failing subtest then could you try the following two patches:

http://lists.freedesktop.org/archives/intel-gfx/2014-May/045038.html
http://lists.freedesktop.org/archives/intel-gfx/2014-May/045037.html
Comment 3 lu hua 2014-05-21 01:02:08 UTC 
It also fails on Haswell.
Comment 4 Guo Jinxian 2014-05-21 05:20:35 UTC 
Created attachment 99465 [details]
dmesg

(In reply to comment #2)
> If this is the only failing subtest then could you try the following two
> patches:
> 
> http://lists.freedesktop.org/archives/intel-gfx/2014-May/045038.html
> http://lists.freedesktop.org/archives/intel-gfx/2014-May/045037.html

The test still failed with the patch.

./pm_rpm --run-subtest system-suspend
IGT-Version: 1.6-g737d248 (x86_64) (Linux: 3.14.0_kcloud_1d7da0_20140521+ x86_64)
Runtime PM support: 1
PC8 residency support: 1
Test assertion failure function igt_get_runtime_pm_status, file igt_aux.c:457:
Last errno: 2, No such file or directory
Failed assertion: false
Unknown status error

Subtest system-suspend: FAIL
Comment 5 Daniel Vetter 2014-05-22 06:46:55 UTC 
Does this work on byt?
Comment 6 Guo Jinxian 2014-05-22 06:58:15 UTC 
(In reply to comment #5)
> Does this work on byt?

No, it doesn't work on byt.
Comment 7 Paulo Zanoni 2014-09-03 20:43:56 UTC 
Can you please retest this and update the affected platforms? It works for me at least on HSW.

Thanks,
Paulo
Comment 8 Guo Jinxian 2014-09-05 07:54:56 UTC 
Test passed on BYT HSW and BDW on latest -nightly(8741309e3741a64c1f83ac1f0b8144452bb83441)

root@x-bytm02:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./pm_rpm --run-subtest system-suspend
IGT-Version: 1.7-g0818875 (x86_64) (Linux: 3.17.0-rc2_drm-intel-nightly_874130_20140905+ x86_64)
Runtime PM support: 1
PC8 residency support: 0
rtcwake: assuming RTC uses UTC ...
rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Sep  5 23:46:53 2014
Subtest system-suspend: SUCCESS
Comment 9 Damien Lespiau 2014-09-05 08:11:37 UTC 
Don't hesitate to close the issue when it has been fixed already.
Comment 10 Jari Tahvanainen 2017-09-04 10:26:45 UTC 
Closing old verified+fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.