| Summary: | Change pagenum arguments in PDFDoc::markAnnotations from Guint to int | ||
|---|---|---|---|
| Product: | poppler | Reporter: | Hib Eris <hib> |
| Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Change pagenum arguments in PDFDoc::markAnnotations from Guint to int | ||
Created attachment 100104 [details] [review] Change pagenum arguments in PDFDoc::markAnnotations from Guint to int Correct, PDFDoc::getPage accepts an int, so no need to use a guint there. Commited to master though, don't want to break BC just because that small warning in the stable branch. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Fixes compile warning: CXX PDFDoc.lo PDFDoc.cc: In member function 'GBool PDFDoc::markAnnotations(Object*, XRef*, XRef*, Guint, Guint, Guint)': PDFDoc.cc:1607:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (obj2.getRef().num == oldPageNum) { ^ PDFDoc.cc:1617:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] } else if (obj2.getRef().num == newPageNum) {