Bug 79410 - Change pagenum arguments in PDFDoc::markAnnotations from Guint to int
Summary: Change pagenum arguments in PDFDoc::markAnnotations from Guint to int
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-29 11:37 UTC by Hib Eris
Modified: 2014-06-03 18:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Change pagenum arguments in PDFDoc::markAnnotations from Guint to int (3.05 KB, patch)
2014-05-29 11:37 UTC, Hib Eris 		Details | Splinter Review
View All

Description Hib Eris 2014-05-29 11:37:07 UTC 
Fixes compile warning:

  CXX      PDFDoc.lo
PDFDoc.cc: In member function 'GBool PDFDoc::markAnnotations(Object*, XRef*, XRef*, Guint, Guint, Guint)':
PDFDoc.cc:1607:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
               if (obj2.getRef().num == oldPageNum) {
                                        ^
PDFDoc.cc:1617:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
               } else if (obj2.getRef().num == newPageNum) {
Comment 1 Hib Eris 2014-05-29 11:37:10 UTC 
Created attachment 100104 [details] [review]
Change pagenum arguments in PDFDoc::markAnnotations from Guint to int
Comment 2 Albert Astals Cid 2014-06-03 18:46:38 UTC 
Correct, PDFDoc::getPage accepts an int, so no need to use a guint there.
Comment 3 Albert Astals Cid 2014-06-03 18:50:35 UTC 
Commited to master though, don't want to break BC just because that small warning in the stable branch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.