| Summary: | Enhancement request: Add option to allow user to select color of non-printing characters | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Pedro <pedlino> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | CC: | cno, quikee, vstuart.foote, william |
| Version: | 4.4.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=79381 https://bugs.freedesktop.org/show_bug.cgi?id=68071 |
||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | PNG capturing difference between initial blue for NPC and new agreed "Solarized blue" | ||
|
Description
Pedro
2014-06-15 15:48:22 UTC
More niche options? Please, no! (In reply to comment #1) > More niche options? Please, no! If the color is so unimportant why did a Developer spend his time changing it? Maybe it is not such a niche... In any case this option will allow users to set it back to black if they so wish (which is something you CAN'T do with the Startup Center) The users can ignore options (staying with the Default) but other users can't ignore HARDCODED changes. Actually it isn't a niche wish at all. The ultimate solution for this problem isn't to provide a way to change the color, but recalculate the color of non printing characters according to the color we have in background (=the color page or in the case of a user is writing in a table,...). This should still be provided as an easy hack IMHO. The decision we reached both in our vote (https://dudle.inf.tu-dresden.de/Non-printing_characters_color/) and in our monthly meeting of june (https://wiki.documentfoundation.org/Design/Meetings/2014-06-29) is to add this option and change the default color to "Solarized blue". Created attachment 101981 [details] PNG capturing difference between initial blue for NPC and new agreed "Solarized blue" The new Design / UX agreed default color for NPC is RGB #268bd2 named "Solarized blue" This clip shows that compared to the existing unnamed blue used for NPC with RGB #6abed3 as implemented in bug 68071 As a default, the new blue is a bit more pronounced on both light and darker back grounds. When the enhancement for a Tools -> Options -> Appearance -> Custom Colors control of the NPC variable NON_PRINTING_CHARACTER_COLOR RGB_COLORDATA can be implemented this color as default should be completely functional. In the interim, would suggest that the newly approved color be overlaid on Tomaž's http://cgit.freedesktop.org/libreoffice/core/commit/?id=fb99a6b9958815eb1ad27179d252a379ce8b79fd and included for the 4.3.0 rc2 build. (In reply to comment #2) > (In reply to comment #1) > > More niche options? Please, no! > > If the color is so unimportant You misunderstood. I said niche OPTIONS, not niche COLORS. Design is trying to remove superflous options to reduce complexity, and IMHO adding a color chooser for non-printing characters is one such superflous setting. If it’s so desperately wanted, it could live buried in Expert Config. Changing component to Writer as the UX Advise has settled on a new color, Solarized Blue (I voted for it as well). Adolfo, (In reply to comment #6) > I said niche OPTIONS, not niche COLORS. Design is trying to remove > superflous options to reduce complexity, and IMHO adding a color chooser for > non-printing characters is one such superflous setting. If it’s so > desperately wanted, it could live buried in Expert Config. Actually, I'd probably disagree with that, because as a reasonable UX customization that has gained Design team approval, setting a custom color from the Appearance panel is a very logical implementation. Additionally as Expert Config remains a horrible hack at this point--it is really not functional at all for efficiency of UI configuration. Especially a joy if you happen to be using AT. IMHO the Tools -> Options -> Appearance -> Custom Colors remains the most direct and efficient way to implement assignment of alternate color to the NON_PRINTING_CHARACTER_COLOR RGB_COLORDATA as manipulating RGB color assignment to variables either directly or more often via enum lists is how this aspect of the UI is customized, see svtools/colorcfg. Implementing remaining facet of this issue probably rates an easy-hack designation. But if combined with the automated adjustment of bug 78381, and a need to handle display of NPC in modules other than writer it becomes a more substantial development effort. (In reply to comment #7) s/79381/78381 Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c0a7a7e499c07627b15072aeb627fcb4897ea4d6&h=libreoffice-4-3 fdo#80054 change color for NPC to "solarized blue" It will be available in LibreOffice 4.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5d4e237049abec3b6c7d13f25d8bb0773d1df5a fdo#80054 change color for NPC to "solarized blue" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "libreoffice-4-3-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbb1806f35815497b4bee7eed5334c697825f82f&h=libreoffice-4-3-0 fdo#80054 change color for NPC to "solarized blue" It will be available already in LibreOffice 4.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I'm rather confused by this issue. The summary asks for an option to select color.. and the commits from Thomasz are changing the color... It this is the request for enhancement, it's a duplicate of bug 79381 :) See the OP, this is to allow user to manually set the fixed color--either a item in Tools -> Options Advanced: Expert Configuration dialog; or a new item in Tools -> Options -> LibreOffice -> Appearance -> Custom colors -> General Bug 79381 was suggestion to algorithmically assign a color based on the foreground and background color of the active document. Removing targets 4.3.1 and 4.4.0 keywords for the commits to reassign the fixed color from #6abed3 to #268bd2 -- as in comment 9 comment 10 UI work to provide user customizable NPC color assignment remains to be accomplished. I strongly support the OP's request. When I reveal Non-Printing Characters, they appear in a blue colour (instead of black). I find this distracting and it interferes with my reading the text. I do not wish to turn off the exposure of the Non-Printing Characters. Al Maloney |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.