Bug 80689

Summary:	hif: Empty offline update results, redux
Product:	PackageKit	Reporter:	Kalev Lember <kalevlember>
Component:	backend-yum	Assignee:	Richard Hughes <richard>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Fix a mixup of HifStateAction and HifPackageInfo Improve rpm callback handling for packages in the cleanup state hif: Fix up a signature mismatch with a libhif signal handler

Description Kalev Lember 2014-06-29 19:59:44 UTC

I was testing offline updates today with the new libhif-based PackageKit 0.9.3, and ended up with an empty Packages= line again.

After a debugging session, it turned out that this time too (similar to https://bugs.freedesktop.org/show_bug.cgi?id=79791) PK thought all those packages were in the CLEANUP state, and because of that didn't write them out to the offline-update-competed file.

The root cause turned out to be an enum mixup in libhif. I've got 2 libhif patches and a PK patch; I'm attaching them all here to make it easier to review them at one place.

Comment 1 Kalev Lember 2014-06-29 20:03:58 UTC

Created attachment 101983 [details] [review]
Fix a mixup of HifStateAction and HifPackageInfo

Comment 2 Kalev Lember 2014-06-29 20:04:35 UTC

Created attachment 101984 [details] [review]
Improve rpm callback handling for packages in the cleanup state

Comment 3 Kalev Lember 2014-06-29 20:06:10 UTC

Created attachment 101985 [details] [review]
hif: Fix up a signature mismatch with a libhif signal handler

Comment 4 Kalev Lember 2014-06-30 19:21:13 UTC

Pushed after IRC review.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.