Bug 8081

Summary:	using new-style function syntax to resolve some x86-64 xtest failures
Product:	Xtests	Reporter:	Gordon Jin <gordon.jin>
Component:	XTS	Assignee:	Stuart Anderson <anderson>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	eich, haihao.xiang, keithp
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	using new style function syntax Delete old declarations in XtTestProto.h trivial patch for check.c

Description Gordon Jin 2006-08-31 01:44:58 UTC

Below 3 xtest cases fail on x86-64 platform:
Xt11/XtVaGetSubresources                4           
Xt11/XtSetSubvalues                     2           
Xt11/XtVaSetSubvalues                   2   

This is a type "long" issue caused by using old-style (implicit) syntax in
function declaration:
int check_dec();
and can be resolved by using new-style (explicit) syntax in function declaration:
int check_dec(long, long, char*);

I can't think out any reason not using new-style, so I'm pushing fix to new-style.

Comment 1 Gordon Jin 2006-08-31 01:57:59 UTC

Created attachment 6759 [details] [review]
using new style function syntax

-- Using -DMIXOLDANDNEW for Xt Toolkit tests in tetbuild.cfg.Linux to choose
new style function syntax.
-- Fix some apparent mistakes under MIXOLDANDNEW section in XtTestProto.h, to
make the type of function declaration consistent with function implementation.
-- Using "%ld" instead of "%d" for long type value in
check_dec()/check_not_dec().

Comment 2 Gordon Jin 2006-09-13 00:49:56 UTC

Created attachment 6938 [details] [review]
Delete old declarations in XtTestProto.h

Update the patch based on mailing list feedback:
-- Delete the old declarations and always use the new-style prototypes in
XtTestProto.h
-- Fix 3 wrong prototypes, to be consistent with function implementation.

Comment 3 Gordon Jin 2006-09-13 00:51:51 UTC

Created attachment 6939 [details] [review]
trivial patch for check.c

replace "%d" with "%ld" when printing long type.

Comment 4 Egbert Eich 2006-09-21 10:00:32 UTC

Any updates on this one? 
The patches look trivial enough to be committed.

Comment 5 Gordon Jin 2007-03-14 19:31:48 UTC

The bug priority was upgraded (P2->high) with the bugzilla configuration change.
I'm Changing the priority back to the normal one.
Sorry for the spam.

btw, can anyone help commit this patch? It has been reviwed for quite a long time.

Comment 6 Gordon Jin 2007-08-07 02:43:28 UTC

Anyone would commit the 2 patches?

Comment 7 Eric Anholt 2007-10-15 13:44:46 UTC

Committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.