Below 3 xtest cases fail on x86-64 platform:
This is a type "long" issue caused by using old-style (implicit) syntax in
and can be resolved by using new-style (explicit) syntax in function declaration:
int check_dec(long, long, char*);
I can't think out any reason not using new-style, so I'm pushing fix to new-style.
Created attachment 6759 [details] [review]
using new style function syntax
-- Using -DMIXOLDANDNEW for Xt Toolkit tests in tetbuild.cfg.Linux to choose
new style function syntax.
-- Fix some apparent mistakes under MIXOLDANDNEW section in XtTestProto.h, to
make the type of function declaration consistent with function implementation.
-- Using "%ld" instead of "%d" for long type value in
Created attachment 6938 [details] [review]
Delete old declarations in XtTestProto.h
Update the patch based on mailing list feedback:
-- Delete the old declarations and always use the new-style prototypes in
-- Fix 3 wrong prototypes, to be consistent with function implementation.
Created attachment 6939 [details] [review]
trivial patch for check.c
replace "%d" with "%ld" when printing long type.
Any updates on this one?
The patches look trivial enough to be committed.
The bug priority was upgraded (P2->high) with the bugzilla configuration change.
I'm Changing the priority back to the normal one.
Sorry for the spam.
btw, can anyone help commit this patch? It has been reviwed for quite a long time.
Anyone would commit the 2 patches?