|Summary:||~2% speedup by avoiding char -> UGooString conversions on Dict::find|
|Product:||poppler||Reporter:||Krzysztof Kowalczyk <kkowalczyk>|
|Status:||RESOLVED WONTFIX||QA Contact:|
|i915 platform:||i915 features:|
|Attachments:||Speedup as described in the bug|
Description Krzysztof Kowalczyk 2006-09-02 17:04:54 UTC
Currently every Dict::find(char *) (which are a majority) needs to convert char * to UGooString, which involves memory allocations. This patch implements ability to directly find(char *) by adding UGooString::cmp(char *) that has the same semantics as UGooString::cmp(UGooString(char*)). Also converting tabs to spaces so that it always has correct indentation (regardless of your current tab settings) and small refactoring to use dictLookupBool() and dictLookupInt() for simpler code.
Comment 1 Krzysztof Kowalczyk 2006-09-02 17:05:46 UTC
Created attachment 6796 [details] [review] Speedup as described in the bug
Comment 2 Jeff Muizelaar 2006-12-10 15:50:56 UTC
It would be easier to review this patch if you had the cosmetic and functional changes in separate patches.
Comment 3 Pino Toscano 2008-10-05 08:04:54 UTC
Is this patch still valid, given that there is no more UGooString?
Comment 4 Albert Astals Cid 2010-02-09 14:57:40 UTC
UGooString doesn't exist anymore