Bug 8111 - ~2% speedup by avoiding char -> UGooString conversions on Dict::find
Summary: ~2% speedup by avoiding char -> UGooString conversions on Dict::find
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Windows (All)
: high normal
Assignee: poppler-bugs
QA Contact:
Depends on:
Reported: 2006-09-02 17:04 UTC by Krzysztof Kowalczyk
Modified: 2010-02-09 14:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Speedup as described in the bug (66.13 KB, patch)
2006-09-02 17:05 UTC, Krzysztof Kowalczyk
Details | Splinter Review

Description Krzysztof Kowalczyk 2006-09-02 17:04:54 UTC
Currently every Dict::find(char *) (which are a majority) needs to convert char
* to UGooString, which involves memory allocations.

This patch implements ability to directly find(char *) by adding
UGooString::cmp(char *) that has the same semantics as

Also converting tabs to spaces so that it always has correct indentation
(regardless of your current tab settings) and small refactoring to use
dictLookupBool() and dictLookupInt() for simpler code.
Comment 1 Krzysztof Kowalczyk 2006-09-02 17:05:46 UTC
Created attachment 6796 [details] [review]
Speedup as described in the bug
Comment 2 Jeff Muizelaar 2006-12-10 15:50:56 UTC
It would be easier to review this patch if you had the cosmetic and functional
changes in separate patches.
Comment 3 Pino Toscano 2008-10-05 08:04:54 UTC
Is this patch still valid, given that there is no more UGooString?
Comment 4 Albert Astals Cid 2010-02-09 14:57:40 UTC
UGooString doesn't exist anymore

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.