Bug 8140

Summary:	DisplayFontParams are cached by name
Product:	poppler	Reporter:	Jeff Muizelaar <jmuizelaar>
Component:	general	Assignee:	Jeff Muizelaar <jmuizelaar>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Rough patch that should fix the problem Just the changes that I meant A replacement patch that achieves the same thing

Description Jeff Muizelaar 2006-09-05 21:33:49 UTC

Caching DisplayFontParams by name is wrong because two fonts can have the same
name but have different font parameters and thus refer to different fonts. This
causes the wrong font to be chosen if a different font happens to have the same
name.

Comment 1 Jeff Muizelaar 2006-09-05 21:36:35 UTC

Created attachment 6832 [details] [review]
Rough patch that should fix the problem

Comment 2 Jeff Muizelaar 2006-09-05 21:37:23 UTC

Created attachment 6833 [details] [review]
Just the changes that I meant

Comment 3 Jeff Muizelaar 2007-05-12 20:05:00 UTC

On a unrelated note, poppler should/could use Flags from the font descriptor when doing font substitution.

Comment 4 Jeff Muizelaar 2007-05-13 14:43:16 UTC

A pdf showing the problems is at: http://gitweb.freedesktop.org/?p=poppler/test;a=blob;h=3e3a4970cfd4e7e5251a3546de97010685c59b9f;hb=79535867d1195e32d0dc0149b5a55357b07ee906;f=tests/fonts.pdf

Comment 5 Jeff Muizelaar 2007-05-13 18:36:16 UTC

Created attachment 9959 [details]
A replacement patch that achieves the same thing

This approach is probably better than the last.

Comment 6 Jeff Muizelaar 2007-05-25 11:44:38 UTC

Fixed in cvs

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.