Bug 8140 - DisplayFontParams are cached by name
Summary: DisplayFontParams are cached by name
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Jeff Muizelaar
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-05 21:33 UTC by Jeff Muizelaar
Modified: 2007-05-25 11:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Rough patch that should fix the problem (6.97 KB, patch)
2006-09-05 21:36 UTC, Jeff Muizelaar 		Details | Splinter Review
Just the changes that I meant (3.00 KB, patch)
2006-09-05 21:37 UTC, Jeff Muizelaar 		Details | Splinter Review
A replacement patch that achieves the same thing (2.37 KB, application/octet-stream)
2007-05-13 18:36 UTC, Jeff Muizelaar 		Details
Show Obsolete (2) View All

Description Jeff Muizelaar 2006-09-05 21:33:49 UTC 
Caching DisplayFontParams by name is wrong because two fonts can have the same
name but have different font parameters and thus refer to different fonts. This
causes the wrong font to be chosen if a different font happens to have the same
name.
Comment 1 Jeff Muizelaar 2006-09-05 21:36:35 UTC 
Created attachment 6832 [details] [review]
Rough patch that should fix the problem
Comment 2 Jeff Muizelaar 2006-09-05 21:37:23 UTC 
Created attachment 6833 [details] [review]
Just the changes that I meant
Comment 3 Jeff Muizelaar 2007-05-12 20:05:00 UTC 
On a unrelated note, poppler should/could use Flags from the font descriptor when doing font substitution.
Comment 5 Jeff Muizelaar 2007-05-13 18:36:16 UTC 
Created attachment 9959 [details]
A replacement patch that achieves the same thing

This approach is probably better than the last.
Comment 6 Jeff Muizelaar 2007-05-25 11:44:38 UTC 
Fixed in cvs

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.