| Summary: | [BDW Bisected] eDP monitor can't be lighted up after S3 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | liulei <lei.a.liu> | ||||||||
| Component: | DRM/Intel | Assignee: | Rodrigo Vivi <rodrigo.vivi> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||
| Severity: | critical | ||||||||||
| Priority: | high | CC: | intel-gfx-bugs, james.ausmus | ||||||||
| Version: | unspecified | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux (All) | ||||||||||
| Whiteboard: | |||||||||||
| i915 platform: | i915 features: | ||||||||||
| Attachments: |
|
||||||||||
|
Description
liulei
2014-07-28 04:28:53 UTC
Created attachment 103572 [details]
dmesg after s3
Created attachment 104324 [details] [review] upda psr on resume Could you please check if the attached patch fix the issue. Thanks, Rodrigo (In reply to comment #2) > Created attachment 104324 [details] [review] [review] > upda psr on resume > > Could you please check if the attached patch fix the issue. > I can't patch your attachment. It will be such wonderful if you can rebase your patch on latest -next-queued. This piece patch failed: --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -3972,6 +3972,11 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc) I915_WRITE(DSPCNTR(plane), DISPPLANE_GAMMA_ENABLE); POSTING_READ(DSPCNTR(plane)); + /* Forcing a full psr init sequence when enabling crtc to make sure all + * registers are properly set. Some might not be persistent after + * suspend/resume cycle. */ + dev_priv->psr.setup_done = false; + dev_priv->display.update_primary_plane(crtc, crtc->primary->fb, crtc->x, crtc->y); I can't find its context. N.B. upstream has commit 27d438c56009e5ae632de36fe70985d1aab5e344 Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Fri Aug 8 11:48:26 2014 -1000 Revert "drm/i915: Enable PSR by default." (In reply to comment #4) > N.B. upstream has > > commit 27d438c56009e5ae632de36fe70985d1aab5e344 > Author: Linus Torvalds <torvalds@linux-foundation.org> > Date: Fri Aug 8 11:48:26 2014 -1000 > > Revert "drm/i915: Enable PSR by default." Bugt 81140 prevent me from tring this commit on upstraem. It worked after I reverted "Enable PSR by default" commit on latest -nightly. I tested latest -nightly (49ceddc7b3b0e3f7eb21b9fb4c9b840cff630047) kernel. eDP monitor is able to be lighted up when the system resumed from S3. The commit referenced in comment #4 is now in nightly. Closing old verified. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.