Created attachment 103571 [details] dmesg before s3 ==System Environment== -------------------------- Regression: Yes. Good commit: eeefa889cddb8d7e4ee6ce0212e685dd624d66a1(-next-queued) ==kernel== -------------------------- -nightly:e967a525207bd40ab446e2f809907039f88e66f3(failed) drm-intel-nightly: 2014y-07m-25d-23h-02m-06s integration manifest -queued: eff9b57c1a91ccf309d57500ab6a365ba7be5712 (failed) drm/i915: Update DRIVER_DATE to 20140725 -fixes: f4be89cecea437aaddd7700d05c6bdb5678041f7 (works) drm/i915: Fix crash when failing to parse MIPI VBT ==Bug detailed description== -------------------------- eDP monitor can't be lighted up after S3 ==Reproduce steps== ---------------------------- 1. do s3 2. check eDP monitor ==Bisect results== ---------------------------- Bisect shows: b6d547791fd3ef4ccc89ad2556ab01045640aef7 is the first bad commit commit b6d547791fd3ef4ccc89ad2556ab01045640aef7 Author: Rodrigo Vivi <rodrigo.vivi@intel.com> AuthorDate: Fri Jul 11 10:30:19 2014 -0700 Commit: Daniel Vetter <daniel.vetter@ffwll.ch> CommitDate: Wed Jul 23 07:05:21 2014 +0200 drm/i915: Enable PSR by default. Panel Self Refresh is an eDP power saving feature specified by VESA's eDP v1.3, that allows some panel componets to shutdown while you still see static images on the screen. Besides being supported on the platform it must be supported by the eDP panel itself. Now that we have the propper frontbuffer tracking support and correct locks on place we can enabled this feature by default.
Created attachment 103572 [details] dmesg after s3
Created attachment 104324 [details] [review] upda psr on resume Could you please check if the attached patch fix the issue. Thanks, Rodrigo
(In reply to comment #2) > Created attachment 104324 [details] [review] [review] > upda psr on resume > > Could you please check if the attached patch fix the issue. > I can't patch your attachment. It will be such wonderful if you can rebase your patch on latest -next-queued. This piece patch failed: --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -3972,6 +3972,11 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc) I915_WRITE(DSPCNTR(plane), DISPPLANE_GAMMA_ENABLE); POSTING_READ(DSPCNTR(plane)); + /* Forcing a full psr init sequence when enabling crtc to make sure all + * registers are properly set. Some might not be persistent after + * suspend/resume cycle. */ + dev_priv->psr.setup_done = false; + dev_priv->display.update_primary_plane(crtc, crtc->primary->fb, crtc->x, crtc->y); I can't find its context.
N.B. upstream has commit 27d438c56009e5ae632de36fe70985d1aab5e344 Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Fri Aug 8 11:48:26 2014 -1000 Revert "drm/i915: Enable PSR by default."
(In reply to comment #4) > N.B. upstream has > > commit 27d438c56009e5ae632de36fe70985d1aab5e344 > Author: Linus Torvalds <torvalds@linux-foundation.org> > Date: Fri Aug 8 11:48:26 2014 -1000 > > Revert "drm/i915: Enable PSR by default." Bugt 81140 prevent me from tring this commit on upstraem. It worked after I reverted "Enable PSR by default" commit on latest -nightly.
I tested latest -nightly (49ceddc7b3b0e3f7eb21b9fb4c9b840cff630047) kernel. eDP monitor is able to be lighted up when the system resumed from S3.
The commit referenced in comment #4 is now in nightly.
Closing old verified.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.