Summary: | MPEG x MPEG-4 conflicts | ||
---|---|---|---|
Product: | shared-mime-info | Reporter: | Stanislav Brabec <sbrabec> |
Component: | freedesktop.org.xml | Assignee: | Jonathan Blandford <jrb> |
Status: | RESOLVED NOTABUG | QA Contact: | |
Severity: | normal | ||
Priority: | high | CC: | bugzilla |
Version: | unspecified | ||
Hardware: | x86 (IA32) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
shared-mime-info-mpeg.patch
shared-mime-info-mpeg.patch |
Description
Stanislav Brabec
2006-09-08 02:52:25 UTC
Created attachment 6878 [details] [review] shared-mime-info-mpeg.patch Proposed patch against shared-mime-info-0.17. Comment on attachment 6878 [details] [review] shared-mime-info-mpeg.patch >--- freedesktop.org.xml.in >+++ freedesktop.org.xml.in >@@ -1843,12 +1843,13 @@ > <_comment>MPEG-4 audio</_comment> > <alias type="audio/x-m4a"/> > <magic priority="50"> >- <match type="string" value="ftypM4A" offset="0"/> >+ <match type="string" value="ftypM4A" offset="4"/> That was already fixed. We're at 0.19 now, maybe time to update. > </magic> > <glob pattern="*.m4a"/> > </mime-type> > <mime-type type="video/mp4"> > <_comment>MPEG-4 video</_comment> >+ <sub-class-of type="video/mpeg"/> > <magic priority="50"> > <match type="string" value="ftypisom" offset="4"/> > <match type="string" value="ftypmp42" offset="4"/> It's a different container altogether, and they shouldn't be mixed. As per last comment. Created attachment 6881 [details] [review] shared-mime-info-mpeg.patch Version for shared-mime-info-0.19. Comment on attachment 6881 [details] [review] shared-mime-info-mpeg.patch >https://bugs.freedesktop.org/show_bug.cgi?id=8186 >================================================================================ >--- freedesktop.org.xml.in >+++ freedesktop.org.xml.in >@@ -1961,6 +1961,7 @@ > </mime-type> > <mime-type type="video/mp4"> > <_comment>MPEG-4 video</_comment> >+ <sub-class-of type="video/mpeg"/> > <magic priority="50"> > <match type="string" value="ftypisom" offset="4"/> > <match type="string" value="ftypmp42" offset="4"/> No, they're different types of video, and video/mp4 isn't a sub-class of video/mpeg. Well. I don't know, what is the consensus for naming of MPEG4 files and whether we should allow *.mpg and *.mpeg for them, too, or only *.mp4 and *.m4v are valid. (In reply to comment #6) > Well. I don't know, what is the consensus for naming of MPEG4 files and whether > we should allow *.mpg and *.mpeg for them, too, or only *.mp4 and *.m4v are valid. It's understood that MPEG4 videos should use mp4, mpeg4, or m4v as a suffix, and that mpeg, and mpg are for MPEG-1 videos (just like MPEG-2 videos usually use VOB). |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.