Bug 8186 - MPEG x MPEG-4 conflicts
Summary: MPEG x MPEG-4 conflicts
Status: RESOLVED NOTABUG
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Jonathan Blandford
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-08 02:52 UTC by Stanislav Brabec
Modified: 2006-09-08 05:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
shared-mime-info-mpeg.patch (603 bytes, patch)
2006-09-08 02:53 UTC, Stanislav Brabec
Details | Splinter Review
shared-mime-info-mpeg.patch (476 bytes, patch)
2006-09-08 04:04 UTC, Stanislav Brabec
Details | Splinter Review

Description Stanislav Brabec 2006-09-08 02:52:25 UTC
For some MPEG-4 file types, Nautilus report MIME type conflict. Attached patch
fixes this problem. It also fixes M4A magic.

I am not sure, whether audio/mp4 (M4A) should be sub-class-of audio/mpeg
(MP2/MP3), but I guess it's a different container type.
Comment 1 Stanislav Brabec 2006-09-08 02:53:14 UTC
Created attachment 6878 [details] [review]
shared-mime-info-mpeg.patch

Proposed patch against shared-mime-info-0.17.
Comment 2 Bastien Nocera 2006-09-08 03:16:19 UTC
Comment on attachment 6878 [details] [review]
shared-mime-info-mpeg.patch

>--- freedesktop.org.xml.in
>+++ freedesktop.org.xml.in
>@@ -1843,12 +1843,13 @@
>     <_comment>MPEG-4 audio</_comment>
>     <alias type="audio/x-m4a"/>
>     <magic priority="50">
>-      <match type="string" value="ftypM4A" offset="0"/>
>+      <match type="string" value="ftypM4A" offset="4"/>

That was already fixed. We're at 0.19 now, maybe time to update.

>     </magic>
>     <glob pattern="*.m4a"/>
>   </mime-type>
>   <mime-type type="video/mp4">
>     <_comment>MPEG-4 video</_comment>
>+    <sub-class-of type="video/mpeg"/>
>     <magic priority="50">
>       <match type="string" value="ftypisom" offset="4"/>
>       <match type="string" value="ftypmp42" offset="4"/>

It's a different container altogether, and they shouldn't be mixed.
Comment 3 Bastien Nocera 2006-09-08 03:19:38 UTC
As per last comment.
Comment 4 Stanislav Brabec 2006-09-08 04:04:44 UTC
Created attachment 6881 [details] [review]
shared-mime-info-mpeg.patch

Version for shared-mime-info-0.19.
Comment 5 Bastien Nocera 2006-09-08 05:00:52 UTC
Comment on attachment 6881 [details] [review]
shared-mime-info-mpeg.patch

>https://bugs.freedesktop.org/show_bug.cgi?id=8186
>================================================================================
>--- freedesktop.org.xml.in
>+++ freedesktop.org.xml.in
>@@ -1961,6 +1961,7 @@
>   </mime-type>
>   <mime-type type="video/mp4">
>     <_comment>MPEG-4 video</_comment>
>+    <sub-class-of type="video/mpeg"/>
>     <magic priority="50">
>       <match type="string" value="ftypisom" offset="4"/>
>       <match type="string" value="ftypmp42" offset="4"/>

No, they're different types of video, and video/mp4 isn't a sub-class of
video/mpeg.
Comment 6 Stanislav Brabec 2006-09-08 05:16:08 UTC
Well. I don't know, what is the consensus for naming of MPEG4 files and whether
we should allow *.mpg and *.mpeg for them, too, or only *.mp4 and *.m4v are valid.
Comment 7 Bastien Nocera 2006-09-08 05:32:51 UTC
(In reply to comment #6)
> Well. I don't know, what is the consensus for naming of MPEG4 files and whether
> we should allow *.mpg and *.mpeg for them, too, or only *.mp4 and *.m4v are valid.

It's understood that MPEG4 videos should use mp4, mpeg4, or m4v as a suffix, and
that mpeg, and mpg are for MPEG-1 videos (just like MPEG-2 videos usually use VOB).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.