Bug 82059

Summary: SplashOutputDev::drawImageMask() has interesting double check of inlineImg boolean
Product: poppler Reporter: Ed Porras <dev>
Component: generalAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: trivial    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch removing extra check

Description Ed Porras 2014-08-02 18:46:06 UTC
Created attachment 103873 [details]
Patch removing extra check

Unless I'm missing something, this looks like a merge issue:

  if (inlineImg) {
    if (inlineImg) {
      while (imgMaskData.y < height) {
        imgMaskData.imgStr->getLine();
        ++imgMaskData.y;
      }
    }
  }

(I didn't select Splash backend since this file is located within the poppler source).
Comment 1 Albert Astals Cid 2014-08-02 23:02:30 UTC
Fixed, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.