Bug 82059 - SplashOutputDev::drawImageMask() has interesting double check of inlineImg boolean
Summary: SplashOutputDev::drawImageMask() has interesting double check of inlineImg bo...
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium trivial
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-02 18:46 UTC by Ed Porras
Modified: 2014-08-02 23:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch removing extra check (516 bytes, text/plain)
2014-08-02 18:46 UTC, Ed Porras 		Details
View All

Description Ed Porras 2014-08-02 18:46:06 UTC 
Created attachment 103873 [details]
Patch removing extra check

Unless I'm missing something, this looks like a merge issue:

  if (inlineImg) {
    if (inlineImg) {
      while (imgMaskData.y < height) {
        imgMaskData.imgStr->getLine();
        ++imgMaskData.y;
      }
    }
  }

(I didn't select Splash backend since this file is located within the poppler source).
Comment 1 Albert Astals Cid 2014-08-02 23:02:30 UTC 
Fixed, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.