Bug 8280

Summary:	Fix all Macintosh layouts
Product:	xkeyboard-config	Reporter:	Denis Barbier <barbier>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	PowerPC
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	41607
Attachments:	Convert Mac layouts to use one group Fix all Mac layouts to use the same template (modifiers, special keys, etc) Cosmetics Make symbols/pc more modular Make keypad modular and reuse definitions for Macs

Description Denis Barbier 2006-09-14 13:21:26 UTC

Hi Sergey,

Changes are splitted into 3 patches, so that they can be
more easily reviewed.  More cleanup will be needed afterwards,
but please commit these 3 patches if you have no problem with
them, otherwise fixing conflicts will require a lot of work.
Thanks

Comment 1 Denis Barbier 2006-09-14 13:23:34 UTC

Created attachment 6984 [details] [review]
Convert Mac layouts to use one group

Layouts have been converted with this simple Perl script, and
manually edited.
  #! /usr/bin/perl
  local $/ = undef;
  $_ = <>;
  s/\]\s*,\s*\n\s*\[/, /g;
  print;

Comment 2 Denis Barbier 2006-09-14 13:25:44 UTC

Created attachment 6985 [details] [review]
Fix all Mac layouts to use the same template (modifiers, special keys, etc)

Comment 3 Denis Barbier 2006-09-14 13:26:31 UTC

Created attachment 6986 [details] [review]
Cosmetics

Comment 4 Denis Barbier 2006-09-15 14:03:02 UTC

Created attachment 6996 [details] [review]
Make symbols/pc more modular

Here are 2 more patches, to apply after previous patches.
The first one modifies symbols/pc so that common
definitions can be called by Macintosh layouts.

Comment 5 Denis Barbier 2006-09-15 14:08:41 UTC

Created attachment 6997 [details] [review]
Make keypad modular and reuse definitions for Macs

Now more interesting things can happen.
Mac keypads behave differently than PC ones, levels 1 and 2
are swapped.  This patch modifies KEYPAD type accordingly
so that keypad definition can be reused for Macs.

Comment 6 Sergey V. Udaltsov 2006-09-17 13:12:57 UTC

Thanks a bunch. Committed. Without much checking for macintosh_vndr stuff ;)

Comment 7 Sergey V. Udaltsov 2011-10-09 05:34:00 UTC

Denis, what would be your opinion regarding bug #41607 ?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.