Bug 8280 - Fix all Macintosh layouts
Summary: Fix all Macintosh layouts
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: PowerPC Linux (All)
: high normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 41607
  Show dependency treegraph
 
Reported: 2006-09-14 13:21 UTC by Denis Barbier
Modified: 2011-10-09 05:34 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Convert Mac layouts to use one group (52.46 KB, patch)
2006-09-14 13:23 UTC, Denis Barbier
Details | Splinter Review
Fix all Mac layouts to use the same template (modifiers, special keys, etc) (17.96 KB, patch)
2006-09-14 13:25 UTC, Denis Barbier
Details | Splinter Review
Cosmetics (16.12 KB, patch)
2006-09-14 13:26 UTC, Denis Barbier
Details | Splinter Review
Make symbols/pc more modular (8.11 KB, patch)
2006-09-15 14:03 UTC, Denis Barbier
Details | Splinter Review
Make keypad modular and reuse definitions for Macs (10.84 KB, patch)
2006-09-15 14:08 UTC, Denis Barbier
Details | Splinter Review

Description Denis Barbier 2006-09-14 13:21:26 UTC
Hi Sergey,

Changes are splitted into 3 patches, so that they can be
more easily reviewed.  More cleanup will be needed afterwards,
but please commit these 3 patches if you have no problem with
them, otherwise fixing conflicts will require a lot of work.
Thanks
Comment 1 Denis Barbier 2006-09-14 13:23:34 UTC
Created attachment 6984 [details] [review]
Convert Mac layouts to use one group

Layouts have been converted with this simple Perl script, and
manually edited.
  #! /usr/bin/perl
  local $/ = undef;
  $_ = <>;
  s/\]\s*,\s*\n\s*\[/, /g;
  print;
Comment 2 Denis Barbier 2006-09-14 13:25:44 UTC
Created attachment 6985 [details] [review]
Fix all Mac layouts to use the same template (modifiers, special keys, etc)
Comment 3 Denis Barbier 2006-09-14 13:26:31 UTC
Created attachment 6986 [details] [review]
Cosmetics
Comment 4 Denis Barbier 2006-09-15 14:03:02 UTC
Created attachment 6996 [details] [review]
Make symbols/pc more modular

Here are 2 more patches, to apply after previous patches.
The first one modifies symbols/pc so that common
definitions can be called by Macintosh layouts.
Comment 5 Denis Barbier 2006-09-15 14:08:41 UTC
Created attachment 6997 [details] [review]
Make keypad modular and reuse definitions for Macs

Now more interesting things can happen.
Mac keypads behave differently than PC ones, levels 1 and 2
are swapped.  This patch modifies KEYPAD type accordingly
so that keypad definition can be reused for Macs.
Comment 6 Sergey V. Udaltsov 2006-09-17 13:12:57 UTC
Thanks a bunch. Committed. Without much checking for macintosh_vndr stuff ;)
Comment 7 Sergey V. Udaltsov 2011-10-09 05:34:00 UTC
Denis, what would be your opinion regarding bug #41607 ?


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.